Decompile Code 8094d28 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikalaxALT
reviewed
Mar 18, 2025
| #ifndef GUARD_RANDOM_MERSENNE_TWISTER_H | ||
| #define GUARD_RANDOM_MERSENNE_TWISTER_H | ||
|
|
||
| void MersenneTwister_InitializeState(u32 seed); |
There was a problem hiding this comment.
Names might be too verbose. Consider mtsrand and mtrand.
There was a problem hiding this comment.
So what do others think? I can rename these functions to mtsrand and mtrand, if that's the only thing blocking the PR.
There was a problem hiding this comment.
Either way works for me. I don't mind long or short names as long as they're descriptive (which both options are here).
|
Gonna merge this for now. We can rename later if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @SethBarberee for his scratches.
YET another rng implementation, just how many are there? LOL
Also wikipedia link for reading https://en.wikipedia.org/wiki/Mersenne_Twister if anyone's curious about this one.